>From Michael Blow <[email protected]>: Michael Blow has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/5483 )
Change subject: [ASTERIXDB-2890] Minimum Java version 8->11 ...................................................................... Patch Set 12: (2 comments) https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/5483/12/hyracks-fullstack/hyracks/hyracks-storage-am-btree/pom.xml File hyracks-fullstack/hyracks/hyracks-storage-am-btree/pom.xml: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/5483/12/hyracks-fullstack/hyracks/hyracks-storage-am-btree/pom.xml@68 PS12, Line 68: <dependency> : <groupId>org.mockito</groupId> : <artifactId>mockito-core</artifactId> : <version>2.28.2</version> : <scope>test</scope> : </dependency> : <dependency> : <groupId>org.powermock</groupId> : <artifactId>powermock-api-mockito2</artifactId> : <version>2.0.9</version> : <scope>test</scope> : </dependency> : <dependency> : <groupId>org.powermock</groupId> : <artifactId>powermock-module-junit4</artifactId> : <version>2.0.9</version> : <scope>test</scope> : </dependency> : <dependency> : <groupId>org.powermock</groupId> : <artifactId>powermock-core</artifactId> : <version>2.0.9</version> : <scope>test</scope> : </dependency> : should we move these versions to hyracks dependency management to keep future updates consolidated? https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/5483/12/pom.xml File pom.xml: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/5483/12/pom.xml@29 PS12, Line 29: 23 why did we need this? you didn't change the parent of either *DB nor hyracks- can we just keep this as 18 as well? -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/5483 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: mad-hatter Gerrit-Change-Id: Ib9aa81fa2e58954846218e9907562685c8cd09e3 Gerrit-Change-Number: 5483 Gerrit-PatchSet: 12 Gerrit-Owner: Michael Blow <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Comment-Date: Fri, 30 Apr 2021 12:46:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
