>From Michael Blow <[email protected]>: Michael Blow has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/11403 )
Change subject: [NO ISSUE][TX] Ensure lock manager computes valid indexes for hash table ...................................................................... Patch Set 2: (1 comment) https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/11403/2/asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/locking/ResourceGroupTable.java File asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/locking/ResourceGroupTable.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/11403/2/asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/locking/ResourceGroupTable.java@44 PS2, Line 44: int h = Math.abs(dId ^ entityHashValue); : if (h < 0) { : // Math.abs returns a negative when the value is Integer.MIN_VALUE : // ensure h is not negative since result sign of m % n is the same as m : h = 0; : } : return table[h % size]; : would table[Math.abs((dId ^ entityHashValue) % size)] be a better pattern? seems like this is the goal -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/11403 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: cheshire-cat Gerrit-Change-Id: I33d342455a79d0d69b49e126ff6a40c47b07d0dd Gerrit-Change-Number: 11403 Gerrit-PatchSet: 2 Gerrit-Owner: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Comment-Date: Mon, 10 May 2021 16:40:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
