>From Hussain Towaileb <[email protected]>: Hussain Towaileb has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/8984 )
Change subject: [ASTERIXDB-2753][EXT] Support reading Parquet from S3 ...................................................................... Patch Set 7: (3 comments) https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/8984/7/asterixdb/asterix-app/src/test/java/org/apache/asterix/common/BinaryFileConverterUtil.java File asterixdb/asterix-app/src/test/java/org/apache/asterix/common/BinaryFileConverterUtil.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/8984/7/asterixdb/asterix-app/src/test/java/org/apache/asterix/common/BinaryFileConverterUtil.java@36 PS7, Line 36: BinaryFileConverterUtil Are these utils only used in tests? If so, can this be moved in a test package? https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/8984/7/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataConstants.java File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataConstants.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/8984/7/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataConstants.java@320 PS7, Line 320: fs.s3a.access.ke For consistency sake, can we call this "fs.s3a.access.key.id"? Or is it an s3-hadoop specific property name? Same goes for the below, fs.s3a.secret.access.key and fs.s3a.service.endpoint. https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/8984/7/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataUtils.java File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataUtils.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/8984/7/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataUtils.java@969 PS7, Line 969: ExternalDataUtils.AwsS3. Is this needed? The listS3Objects is in the same class. -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/8984 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I7a8f1a9dc31d8b4af508e521d010e2ed10feb7dd Gerrit-Change-Number: 8984 Gerrit-PatchSet: 7 Gerrit-Owner: Wael Alkowaileet <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Wael Alkowaileet <[email protected]> Gerrit-Comment-Date: Fri, 18 Jun 2021 14:46:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
