>From Ali Alsuliman <[email protected]>:

Ali Alsuliman has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/12065 )

Change subject: [ASTERIXDB-2791][IDX] Make BTree secondary indexes accept 
NULLs/MISSINGs
......................................................................


Patch Set 6:

(1 comment)

> Patch Set 5: Code-Review+2
>
> Let's file issues to track updating the following accept null/missing:
> insert operator, load statement, and array indexes.

Sure

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/12065/5/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/utils/SecondaryBTreeOperationsHelper.java
File 
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/utils/SecondaryBTreeOperationsHelper.java:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/12065/5/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/utils/SecondaryBTreeOperationsHelper.java@a92
PS5, Line 92:             // If any of the secondary fields are nullable, then 
add a select op that filters nulls.
> The same change needs to be applied to the 
> SecondaryArrayIndexBTreeOperationsHelper class (inside th […]
Ack



--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/12065
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: I3342caa38f52d8d7019bbcd5bf81fc0cc01ca110
Gerrit-Change-Number: 12065
Gerrit-PatchSet: 6
Gerrit-Owner: Ali Alsuliman <[email protected]>
Gerrit-Reviewer: Ali Alsuliman <[email protected]>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Glenn Galvizo <[email protected]>
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Reviewer: Michael Blow <[email protected]>
Gerrit-Reviewer: Murtadha Hubail <[email protected]>
Gerrit-Reviewer: Till Westmann <[email protected]>
Gerrit-Comment-Date: Wed, 07 Jul 2021 17:19:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Glenn Galvizo <[email protected]>
Gerrit-MessageType: comment

Reply via email to