Michael Blow has posted comments on this change. Change subject: Modularize feed adaptors ......................................................................
Patch Set 8: (9 comments) https://asterix-gerrit.ics.uci.edu/#/c/1430/8/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/HDFSDataSourceFactory.java File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/HDFSDataSourceFactory.java: Line 79: private static final List recordReaderNames = Collections.unmodifiableList(Arrays.asList("hdfs")); List<String>? Line 234: public List getRecordReaderNames() { List<String>? https://asterix-gerrit.ics.uci.edu/#/c/1430/8/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/StreamRecordReaderFactory.java File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/StreamRecordReaderFactory.java: Line 49: private static final List<String> recordReaderNames = Collections.unmodifiableList(Arrays.asList(ExternalDataConstants.ALIAS_LOCALFS_ADAPTER, > MAJOR SonarQube violation: +1 https://asterix-gerrit.ics.uci.edu/#/c/1430/8/asterixdb/asterix-villain/adaptor-rss/pom.xml File asterixdb/asterix-villain/adaptor-rss/pom.xml: Line 38: <version>1.2.17</version> i think this version can be inherited Line 53: <version>${hyracks.version}</version> i think these hyracks & algebricks versions can be removed (inherited) https://asterix-gerrit.ics.uci.edu/#/c/1430/8/asterixdb/asterix-villain/adaptor-twitter/pom.xml File asterixdb/asterix-villain/adaptor-twitter/pom.xml: Line 29: <version>2.8.4</version> inherit this version? https://asterix-gerrit.ics.uci.edu/#/c/1430/8/asterixdb/asterix-villain/adaptor-twitter/src/main/java/org/apache/asterix/villain/external/reader/TwitterRecordReaderFactory.java File asterixdb/asterix-villain/adaptor-twitter/src/main/java/org/apache/asterix/villain/external/reader/TwitterRecordReaderFactory.java: Line 57: ExternalDataConstants.READER_PULL_TWITTER, ExternalDataConstants.READER_USER_STREAM_TWITTER)); would this be more readable with one per line? e.g. private static final List<String> recordReaderNames = Collections.unmodifiableList(Arrays.asList( ExternalDataConstants.READER_TWITTER_PULL, ExternalDataConstants.READER_TWITTER_PUSH, ExternalDataConstants.READER_PUSH_TWITTER, ExternalDataConstants.READER_TWITTER_PUSH, ExternalDataConstants.READER_PUSH_TWITTER, ExternalDataConstants.READER_PULL_TWITTER, ExternalDataConstants.READER_USER_STREAM_TWITTER, ExternalDataConstants.READER_PULL_TWITTER, ExternalDataConstants.READER_USER_STREAM_TWITTER )); https://asterix-gerrit.ics.uci.edu/#/c/1430/8/asterixdb/asterix-villain/villain-test-framework/pom.xml File asterixdb/asterix-villain/villain-test-framework/pom.xml: Line 74: <version>${hadoop.version}</version> i think this version can be inherited Line 81: <version>4.12</version> inherit version -- To view, visit https://asterix-gerrit.ics.uci.edu/1430 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic4f95255f5493a813ee1f875b63a62e74bc47602 Gerrit-PatchSet: 8 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang <xkk...@gmail.com> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Michael Blow <mb...@apache.org> Gerrit-Reviewer: Till Westmann <ti...@apache.org> Gerrit-Reviewer: Xikui Wang <xkk...@gmail.com> Gerrit-HasComments: Yes
