>From Ian Maxon <[email protected]>: Ian Maxon has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/10826 )
Change subject: [ASTERIXDB-2849][RT] Fix Python UDF string serde ...................................................................... Patch Set 7: (2 comments) moved to cheshire-cat... so fix is there https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/10826/7/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/msgpack/MessagePackerFromADM.java File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/msgpack/MessagePackerFromADM.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/10826/7/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/msgpack/MessagePackerFromADM.java@223 PS7, Line 223: put > What if the string is larger than the cBuf? yeah this is broken. i fixed it in the parent but it makes more sense to fix it here. https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/10826/7/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/msgpack/MessageUnpackerToADM.java File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/msgpack/MessageUnpackerToADM.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/10826/7/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/msgpack/MessageUnpackerToADM.java@290 PS7, Line 290: stringCharBuffer > Same here, what if len > stringCharBuffer size? yeah same issue and resolution here -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/10826 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I5af4da999985afcc33cdfacea79576f1d6109174 Gerrit-Change-Number: 10826 Gerrit-PatchSet: 7 Gerrit-Owner: Ian Maxon <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Glenn Galvizo <[email protected]> Gerrit-Reviewer: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Wael Alkowaileet <[email protected]> Gerrit-Comment-Date: Mon, 09 Aug 2021 18:20:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Wael Alkowaileet <[email protected]> Gerrit-MessageType: comment
