>From Wael Alkowaileet <[email protected]>: Wael Alkowaileet has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/12643 )
Change subject: [ASTERIXDB-2895][RT] Vsize buffers in PyUDF IPC ...................................................................... Patch Set 25: (4 comments) https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/12643/25/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/builders/StdToModifiedUTF8DataOutputFactory.java File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/builders/StdToModifiedUTF8DataOutputFactory.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/12643/25/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/builders/StdToModifiedUTF8DataOutputFactory.java@28 PS25, Line 28: StdToModifiedUTF8DataOutputFactory Remove :-) https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/12643/25/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/msgpack/MessageUnpackerToADM.java File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/msgpack/MessageUnpackerToADM.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/12643/25/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/msgpack/MessageUnpackerToADM.java@219 PS25, Line 219: unpackArray Use ListBuilder (as discussed) https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/12643/25/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/msgpack/MessageUnpackerToADM.java@246 PS25, Line 246: unpackMap Use RecordBuilder. As discussed, you can address it in another patch. https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/12643/25/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/msgpack/MsgPackAccessors.java File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/msgpack/MsgPackAccessors.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/12643/25/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/msgpack/MsgPackAccessors.java@247 PS25, Line 247: visit Call IVisitablePointable#accept() instead of visit(). Same of the other calls for visit() -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/12643 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: Ic95e592b42139b4750af8bb20291f926b3c973e2 Gerrit-Change-Number: 12643 Gerrit-PatchSet: 25 Gerrit-Owner: Ian Maxon <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Wael Alkowaileet <[email protected]> Gerrit-Comment-Date: Tue, 02 Nov 2021 02:27:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
