>From Dmitry Lychagin <[email protected]>: Dmitry Lychagin has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/14027 )
Change subject: [NO ISSUE][FUN] Add cast-null functions for constructors ...................................................................... Patch Set 3: (2 comments) https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/14027/3/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/utils/TypeUtil.java File asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/utils/TypeUtil.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/14027/3/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/utils/TypeUtil.java@70 PS3, Line 70: public static FunctionIdentifier getTypeConstructor(IAType type) { We should rename it to getTypeConstructorDefaultNull() to avoid possible confusion https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/14027/3/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/utils/TypeUtil.java@114 PS3, Line 114: public static FunctionIdentifier getTypeConstructorWithFormat(IAType type) { We should rename it to getTypeConstructorWithFormatDefaultNull() to avoid possible confusion -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/14027 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I120d18c4c7bbcf098fceaa6784cce265a2811e3b Gerrit-Change-Number: 14027 Gerrit-PatchSet: 3 Gerrit-Owner: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Comment-Date: Thu, 11 Nov 2021 20:08:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
