>From Dmitry Lychagin <dmitry.lycha...@couchbase.com>: Dmitry Lychagin has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/14164 )
Change subject: [NO ISSUE][COMP] Add datetime format for CREATE INDEX ...................................................................... Patch Set 4: Code-Review+2 (7 comments) https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/14164/4/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceSecondaryIndexInsertDeleteRule.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceSecondaryIndexInsertDeleteRule.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/14164/4/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceSecondaryIndexInsertDeleteRule.java@1199 PS4, Line 1199: private final String extraArg; // currently, only for datetime constructor functions with the format arg Can we change the type of extraArg to IAObject instead of String? (in a separate change) https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/14164/4/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/function/DumpIndexReader.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/function/DumpIndexReader.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/14164/4/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/function/DumpIndexReader.java@109 PS4, Line 109: if (isTemporal(tag)) { I think at some point we should consider changing this code to use CleanJSONPrinterFactoryProvider for printing ADM as JSON. https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/14164/4/asterixdb/asterix-app/src/test/resources/optimizerts/queries/btree-index-selection/cast-default-null/cast-default-null-13.sqlpp File asterixdb/asterix-app/src/test/resources/optimizerts/queries/btree-index-selection/cast-default-null/cast-default-null-13.sqlpp: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/14164/4/asterixdb/asterix-app/src/test/resources/optimizerts/queries/btree-index-selection/cast-default-null/cast-default-null-13.sqlpp@33 PS4, Line 33: WHERE v.f_dt < datetime('2020-12-20T00:00:00Z') minor. I'd remove 'Z' from this string because our datetime datatype doesn't support timezone. https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/14164/4/asterixdb/asterix-app/src/test/resources/optimizerts/queries/btree-index-selection/cast-default-null/cast-default-null-16.sqlpp File asterixdb/asterix-app/src/test/resources/optimizerts/queries/btree-index-selection/cast-default-null/cast-default-null-16.sqlpp: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/14164/4/asterixdb/asterix-app/src/test/resources/optimizerts/queries/btree-index-selection/cast-default-null/cast-default-null-16.sqlpp@34 PS4, Line 34: WHERE v.f_dt_fmt < datetime('2020-12-20T00:00:00Z') minor. let's remove 'Z' from this string. https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/14164/4/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/index-selection/cast-default-null/cast-default-null.12.query.sqlpp File asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/index-selection/cast-default-null/cast-default-null.12.query.sqlpp: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/14164/4/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/index-selection/cast-default-null/cast-default-null.12.query.sqlpp@24 PS4, Line 24: WHERE v.f_dt_fmt < datetime('2020-12-20T00:00:00Z') minor. let's remove 'Z' from this string https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/14164/4/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/index-selection/cast-default-null/cast-default-null.15.query.sqlpp File asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/index-selection/cast-default-null/cast-default-null.15.query.sqlpp: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/14164/4/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/index-selection/cast-default-null/cast-default-null.15.query.sqlpp@24 PS4, Line 24: WHERE v.f_dt < datetime('2020-12-20T00:00:00Z') minor. let's remove 'Z' from this string https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/14164/4/asterixdb/asterix-app/src/test/resources/runtimets/results/ddl/index-cast-null/index-cast-null.016.adm File asterixdb/asterix-app/src/test/resources/runtimets/results/ddl/index-cast-null/index-cast-null.016.adm: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/14164/4/asterixdb/asterix-app/src/test/resources/runtimets/results/ddl/index-cast-null/index-cast-null.016.adm@4 PS4, Line 4: { "values": [ "\"date\": { 2019-01-20 }", 4 ] } Just curious, why 'date' field is printed escaped ("\"date\"), but 'datetime' and 'time' field names are not escaped? -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/14164 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I087bb2bd79ba1ccfb9a6bbc910dfdb854b75dc9b Gerrit-Change-Number: 14164 Gerrit-PatchSet: 4 Gerrit-Owner: Ali Alsuliman <ali.al.solai...@gmail.com> Gerrit-Reviewer: Ali Alsuliman <ali.al.solai...@gmail.com> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin <dmitry.lycha...@couchbase.com> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Michael Blow <mb...@apache.org> Gerrit-Reviewer: Murtadha Hubail <mhub...@apache.org> Gerrit-Reviewer: Till Westmann <ti...@apache.org> Gerrit-Comment-Date: Mon, 29 Nov 2021 23:02:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
