>From Dmitry Lychagin <[email protected]>: Dmitry Lychagin has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/14323 )
Change subject: [NO ISSUE][COMP] Support overrding type of closed field with CAST ...................................................................... Patch Set 1: (3 comments) https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/14323/1/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/utils/TypeUtil.java File asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/utils/TypeUtil.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/14323/1/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/utils/TypeUtil.java@204 PS1, Line 204: public ARecordType build(boolean castDefaultNull) throws AlgebricksException { Let's move castDefaultNull parameter from build() to reset(). This makes sense logically and will make the code a bit easier. https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/14323/1/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/utils/TypeUtil.java@305 PS1, Line 305: if (!ATypeHierarchy.canPromote(enforcedFieldType.getTypeTag(), this.keyFieldType.getTypeTag()) I'd rewrite this block as follows: if (castDefaultNull) { recordNameTypesMap.put(...) } else if (!ATypeHierarchy.canPromote(...)) { throw new AsterixException(...) } https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/14323/1/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/utils/TypeUtil.java@316 PS1, Line 316: if (enforcedFieldType == null) { replace if (enforcedFieldType == null) with just else? so line 304 would become: if (enforcedFielType!= null) { lines 305-314 } else { lines 317-318 ... } -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/14323 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I63cb476577c746e9b49906f4fb9f284a23e99cd1 Gerrit-Change-Number: 14323 Gerrit-PatchSet: 1 Gerrit-Owner: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Comment-Date: Sat, 04 Dec 2021 01:47:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
