>From Dmitry Lychagin <dmitry.lycha...@couchbase.com>: Dmitry Lychagin has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/15283 )
Change subject: [NO ISSUE][COMP] Extension-specific SET statements ...................................................................... Patch Set 3: (1 comment) https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/15283/3/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/compiler/provider/ILangCompilationProvider.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/compiler/provider/ILangCompilationProvider.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/15283/3/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/compiler/provider/ILangCompilationProvider.java@75 PS3, Line 75: return new HashSet<>(Set.of(CompilerProperties.COMPILER_JOINMEMORY_KEY, Can we move this set to SqlppCompilationProvider and declare this method as non-default? Let's also rename it to getCompilerOptions(): Set<String> getCompilerOptions(); -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/15283 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: Ib6bafec178b959025e8822925eb27cd41d8bef03 Gerrit-Change-Number: 15283 Gerrit-PatchSet: 3 Gerrit-Owner: Glenn Galvizo <ggalv...@uci.edu> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Glenn Galvizo <ggalv...@uci.edu> Gerrit-Reviewer: Ian Maxon <ima...@uci.edu> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-CC: Dmitry Lychagin <dmitry.lycha...@couchbase.com> Gerrit-Comment-Date: Wed, 16 Feb 2022 18:32:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
