>From Till Westmann <[email protected]>: Attention is currently required from: Nam Duong. Till Westmann has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17295 )
Change subject: [NO ISSUE][FUN] Implement array_swap, array_move, array_bin_search ...................................................................... Patch Set 2: (4 comments) Patchset: PS2: Just a few licensing/formatting comments. File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/ArrayBinarySearchDescriptor.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17295/comment/bd14f3f1_7b3a7f85 PS1, Line 1: package We need to add the Apache license header to all files that don't have it. https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17295/comment/b59c5549_e2edfc91 PS1, Line 13: import org.apache.asterix.om.types.*; We should avoid "*" imports. There's a setting in the IDE to ensure that the IDE doesn't introduce "*" imports. https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17295/comment/dce54624_eae40696 PS1, Line 137: // if found Let's keep comments to 120 characters or less. -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17295 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I2d526d90f04e62a3cc860775103254bd46d530b9 Gerrit-Change-Number: 17295 Gerrit-PatchSet: 2 Gerrit-Owner: Nam Duong <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-CC: Anon. E. Moose #1000171 Gerrit-CC: Till Westmann <[email protected]> Gerrit-Attention: Nam Duong <[email protected]> Gerrit-Comment-Date: Tue, 29 Nov 2022 18:44:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
