>From Nam Duong <[email protected]>: Attention is currently required from: Wail Alkowaileet, Till Westmann. Nam Duong has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17295 )
Change subject: [NO ISSUE][FUN] Implement array_swap, array_move, array_bin_search ...................................................................... Patch Set 8: Code-Review+1 (2 comments) File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/ArrayBinarySearchDescriptor.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17295/comment/00e8065d_ba0cf8cb PS7, Line 193: midIndex > If you are using IntelliJ, you probably got a warning to not modify a value > of an argument. […] Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17295/comment/adbed2f1_f515cbe5 PS7, Line 217: listAccessor.getOrWriteItem(midIndex, tempVal1, storage); > We don't have to write to the storage every time here. […] Done -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17295 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I2d526d90f04e62a3cc860775103254bd46d530b9 Gerrit-Change-Number: 17295 Gerrit-PatchSet: 8 Gerrit-Owner: Nam Duong <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Nam Duong <[email protected]> Gerrit-Reviewer: Wail Alkowaileet <[email protected]> Gerrit-CC: Till Westmann <[email protected]> Gerrit-Attention: Wail Alkowaileet <[email protected]> Gerrit-Attention: Till Westmann <[email protected]> Gerrit-Comment-Date: Thu, 05 Jan 2023 20:21:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Wail Alkowaileet <[email protected]> Gerrit-MessageType: comment
