>From Vijay Sarathy <vijay.sara...@couchbase.com>: Attention is currently required from: Wail Alkowaileet, Ali Alsuliman, Till Westmann. Vijay Sarathy has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17313 )
Change subject: PLEASE EDIT to provide a meaningful commit message! Add cost/card to explain string plan ...................................................................... Patch Set 8: (8 comments) Patchset: PS8: Please review again. File asterixdb/asterix-app/src/test/resources/runtimets/results/explain/explain_field_access_closed/explain_field_access_closed.1.plan: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17313/comment/0d398680_daf98e81 PS4, Line 39: 51 > Hmm.. […] Not sure, this change has no relationship to this. File asterixdb/asterix-app/src/test/resources/runtimets/results/external-dataset/common/parquet/array-access-pushdown/array-access-pushdown.15.plan: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17313/comment/ec202f34_d622cc80 PS4, Line 18: aggregate [$$42] <- [empty-stream()] > We should also include the costs in a subplan. Done. File asterixdb/asterix-app/src/test/resources/runtimets/results/external-dataset/common/parquet/field-access-pushdown/field-access-pushdown.13.plan: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17313/comment/1460bc79_d888e3c8 PS4, Line 1: cardinality: 1000000.0 > Maybe not related to this change. […] This is because for queries that do not go through CBO (for e.g. outer joins or single table queries), no cardinalities are available. Note that single table queries will be supported very soon, but the change is not merged in yet. File hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/prettyprint/AbstractLogicalOperatorPrettyPrintVisitor.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17313/comment/ccd92aa6_4cdad97a PS4, Line 61: for (Map.Entry<String, Object> anno : op.getAnnotations().entrySet()) { : if (anno.getValue() != null && anno.getKey().equals(OperatorAnnotations.OP_OUTPUT_CARDINALITY)) { : cardinality = (double) anno.getValue(); : } else if (anno.getValue() != null && anno.getKey().equals(OperatorAnnotations.OP_COST_TOTAL)) { : cost = (double) anno.getValue(); : } : } > We do not need to loop through the annotations. We can get the values for > both OperatorAnnotations. […] Done. https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17313/comment/fd0b99ba_51f1ad80 PS4, Line 77: HashMap<String, Double> > We probably can break down this method and the one above. […] Done. File hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/prettyprint/LogicalOperatorPrettyPrintVisitor.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17313/comment/d5d4b1f3_45a9ceda PS4, Line 129: + > Let's avoid string concatenation. For example: […] Done. https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17313/comment/e4ce8294_8c977fca PS4, Line 137: cardinality > Let's declare those constants as static final members in > AbstractLogicalOperatorPrettyPrintVisitor s […] Done. -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17313 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: Ie697b90cd4396208ab8f59c68e20ced236903fb8 Gerrit-Change-Number: 17313 Gerrit-PatchSet: 8 Gerrit-Owner: Vijay Sarathy <vijay.sara...@couchbase.com> Gerrit-Reviewer: Ali Alsuliman <ali.al.solai...@gmail.com> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Till Westmann <t...@couchbase.com> Gerrit-Reviewer: Vijay Sarathy <vijay.sara...@couchbase.com> Gerrit-Reviewer: Wail Alkowaileet <wael....@gmail.com> Gerrit-Attention: Wail Alkowaileet <wael....@gmail.com> Gerrit-Attention: Ali Alsuliman <ali.al.solai...@gmail.com> Gerrit-Attention: Till Westmann <t...@couchbase.com> Gerrit-Comment-Date: Mon, 23 Jan 2023 18:24:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Wail Alkowaileet <wael....@gmail.com> Gerrit-MessageType: comment
