>From Ali Alsuliman <[email protected]>: Attention is currently required from: Wail Alkowaileet. Ali Alsuliman has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17300 )
Change subject: [ASTERIXDB-3103][COMP] Extract non-pure functions ...................................................................... Patch Set 6: (1 comment) File hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/InlineVariablesRule.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17300/comment/47b7e9ab_3ac2bae5 PS6, Line 215: && usedVariableCounter.containsKey(variable) : && usedVariableCounter.get(variable).getValue() > 1 I didn't quite get this part. we probably need a comment to explain why this is needed and why we need to count the number of times a variable is used. -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17300 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: neo Gerrit-Change-Id: I59c524a109ef8e18a11844a96b690eac115b27f0 Gerrit-Change-Number: 17300 Gerrit-PatchSet: 6 Gerrit-Owner: Wail Alkowaileet <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Wail Alkowaileet <[email protected]> Gerrit-Attention: Wail Alkowaileet <[email protected]> Gerrit-Comment-Date: Sat, 04 Feb 2023 08:31:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
