>From Murtadha Hubail <[email protected]>: Attention is currently required from: Peeyush Gupta, Ali Alsuliman. Murtadha Hubail has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17485 )
Change subject: [NO ISSUE][OTH] Create dataset without type specification ...................................................................... Patch Set 3: Code-Review+2 (3 comments) File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/physical/BTreeSearchPOperator.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17485/comment/9fc6829f_f3f1b63d PS3, Line 147: ARecordType datasetType = (ARecordType) metadataProvider.findType(dataset); : ARecordType metaItemType = (ARecordType) metadataProvider.findMetaType(dataset); : datasetType = (ARecordType) metadataProvider.findTypeForDatasetWithoutType(datasetType, : metaItemType, dataset); we can potentially refactor all of these 3 calls to a single call that will return a new object encapsulating the dataset type, meta type, and the resolved type. File asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/MetadataManagerUtil.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17485/comment/f997e6d3_8e611abe PS3, Line 78: findTypeForDatasetWithoutType this isn't really finding the type for dataset without a type. It can potentially return the same type it was passed to it. Maybe we can rename it to resolveType File asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/MetadataProvider.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17485/comment/46a77a00_f29f7d88 PS3, Line 368: findTypeForDatasetWithoutType Same comment as MetadataManagerUtil.findTypeForDatasetWithoutType -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17485 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I333d2b0dbbccef51dd3a11c611af10ac6a665ee3 Gerrit-Change-Number: 17485 Gerrit-PatchSet: 3 Gerrit-Owner: Peeyush Gupta <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Peeyush Gupta <[email protected]> Gerrit-Attention: Peeyush Gupta <[email protected]> Gerrit-Attention: Ali Alsuliman <[email protected]> Gerrit-Comment-Date: Fri, 14 Apr 2023 01:38:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
