>From Ian Maxon <[email protected]>:

Attention is currently required from: Wail Alkowaileet, Ali Alsuliman.
Ian Maxon has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17601 )

Change subject: [ASTERIXDB-3204][SQL][MTD] ANALYZE DATASET *
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

File 
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/utils/MetadataLockUtil.java:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17601/comment/81c868c6_6e3429e3
PS1, Line 316:  if ("*".equals(datasetName)) {
             :             lockMgr.acquireDataverseWriteLock(locks, 
dataverseName);
             :         } else {
             :             lockMgr.acquireDataverseReadLock(locks, 
dataverseName);
             :             lockMgr.acquireDatasetCreateIndexLock(locks, 
dataverseName, datasetName);
             :         }
i'm not really a fan of this, but i also can't think of a different way to do it



--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17601
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: Ib5e1b2efefe38332ea1f8f7328c63ace12ac9ceb
Gerrit-Change-Number: 17601
Gerrit-PatchSet: 1
Gerrit-Owner: Ian Maxon <[email protected]>
Gerrit-Reviewer: Ali Alsuliman <[email protected]>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon <[email protected]>
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Reviewer: Wail Alkowaileet <[email protected]>
Gerrit-Attention: Wail Alkowaileet <[email protected]>
Gerrit-Attention: Ali Alsuliman <[email protected]>
Gerrit-Comment-Date: Tue, 20 Jun 2023 18:53:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Reply via email to