>From Murtadha Al Hubail <[email protected]>: Attention is currently required from: Peeyush Gupta, Ali Alsuliman. Murtadha Al Hubail has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17598 )
Change subject: [NO ISSUE][TX]: Statement level atomicity for inserts/upserts/deletes ...................................................................... Patch Set 4: (2 comments) File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/cc/GlobalTxManager.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17598/comment/b770fc15_03946f53 PS4, Line 69: context.wait(); is it safe to just wait for any notification here or should we until some tx state is reached? File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17598/comment/04b96c56_6fdf342f PS3, Line 3511: JobUtils.runJob > You are right, this can issue you mentioned. […] How about this? 1. Make GlobalTxManager implement IJobLifecycleListener and register it as a listener. 2. Create a new object with the required info (e.g. atomic + datasets) for the txn and set it as a property in the job spec. 3. In GlobalTxManager#notifyJobCreation begin the tx if the job has the new property. -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17598 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I3b4aefeba07be921d128255393aec1b703198a40 Gerrit-Change-Number: 17598 Gerrit-PatchSet: 4 Gerrit-Owner: Peeyush Gupta <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Al Hubail <[email protected]> Gerrit-Attention: Peeyush Gupta <[email protected]> Gerrit-Attention: Ali Alsuliman <[email protected]> Gerrit-Comment-Date: Wed, 05 Jul 2023 20:44:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Murtadha Al Hubail <[email protected]> Comment-In-Reply-To: Peeyush Gupta <[email protected]> Gerrit-MessageType: comment
