>From Murtadha Hubail <[email protected]>: Attention is currently required from: Peeyush Gupta, Ali Alsuliman. Murtadha Hubail has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17643 )
Change subject: [NO ISSUE][TX]: Multiple fixes to atomic statements ...................................................................... Patch Set 4: (1 comment) File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/cc/GlobalTxManager.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17643/comment/2d24ccdc_4f9ecfe1 PS4, Line 75: 10 why do you need this? shouldn't there be a notify every time an ack is received? Also, is there a failure scenario that would make this wait forever? -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17643 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: Ieb029d6273f19fa4bd0e7edfb8897f894c1f5b6e Gerrit-Change-Number: 17643 Gerrit-PatchSet: 4 Gerrit-Owner: Peeyush Gupta <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Peeyush Gupta <[email protected]> Gerrit-Attention: Peeyush Gupta <[email protected]> Gerrit-Attention: Ali Alsuliman <[email protected]> Gerrit-Comment-Date: Fri, 21 Jul 2023 14:42:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
