Ian Maxon has posted comments on this change.

Change subject: Debian Packaging for NCService
......................................................................


Patch Set 3:

(5 comments)

https://asterix-gerrit.ics.uci.edu/#/c/1492/3/asterixdb/asterix-server/src/deb/control/control
File asterixdb/asterix-server/src/deb/control/control:

PS3, Line 21: Ian Maxon <[email protected]>
> Should this be a person, or should we use the dev or some other mlist?
Most examples I see have it as one person


PS3, Line 22: The AsterixDB parallel Big Data Management System
> Should we use this heading adapted from the https://asterixdb.apache.org/ s
Good point


https://asterix-gerrit.ics.uci.edu/#/c/1492/3/asterixdb/asterix-server/src/deb/systemd/asterix-cc.service
File asterixdb/asterix-server/src/deb/systemd/asterix-cc.service:

PS3, Line 25: 
> should we have two blank lines here?
Done


PS3, Line 28: 
> remove extra trailing newline?
Done


https://asterix-gerrit.ics.uci.edu/#/c/1492/3/asterixdb/asterix-server/src/deb/systemd/asterix-nc.service
File asterixdb/asterix-server/src/deb/systemd/asterix-nc.service:

PS3, Line 25: 
> should we have two blank lines here?
Done


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1492
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1b5d0895ed5a34700d4e2f666715b857ce275127
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon <[email protected]>
Gerrit-Reviewer: Ian Maxon <[email protected]>
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Reviewer: Michael Blow <[email protected]>
Gerrit-HasComments: Yes

Reply via email to