>From Peeyush Gupta <[email protected]>: Attention is currently required from: Murtadha Al Hubail, Ali Alsuliman. Peeyush Gupta has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17724 )
Change subject: [NO ISSUE][TX][TEST] Add test for atomic statments ...................................................................... Patch Set 8: Code-Review+1 (1 comment) Patchset: PS8: This patch still does not take care of one issue, which I will like to fix in a separate patch. The issue is if an exception occurs while processing a AtomicJobCommitMessage (e.g., fail to write at S3), we will start a rollback after a timeout is reached at CC. However, the rollback currently only removes the checkpoints but does not remove the temporary disk components already loaded for queries to read. For this, we need to deactivate the index (wait for readers to finish), delete the temporary disk components and reactivate it. This is not an issue with atomic statements for metadata txns because when a metadata commit fails we always halt. -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17724 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: Ifcaa65690ca99681cc5bebd8f220e5389298d61b Gerrit-Change-Number: 17724 Gerrit-PatchSet: 8 Gerrit-Owner: Peeyush Gupta <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Al Hubail <[email protected]> Gerrit-Reviewer: Peeyush Gupta <[email protected]> Gerrit-Attention: Murtadha Al Hubail <[email protected]> Gerrit-Attention: Ali Alsuliman <[email protected]> Gerrit-Comment-Date: Tue, 22 Aug 2023 21:23:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
