Till Westmann has submitted this change and it was merged. Change subject: Report integer metrics as numbers ......................................................................
Report integer metrics as numbers Change-Id: Ie330ba0e030d188adbf675741c382cf2754853f1 Reviewed-on: https://asterix-gerrit.ics.uci.edu/1496 Sonar-Qube: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Tested-by: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Integration-Tests: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Reviewed-by: Ian Maxon <ima...@apache.org> --- M asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryServiceServlet.java 1 file changed, 11 insertions(+), 4 deletions(-) Approvals: Ian Maxon: Looks good to me, approved Jenkins: Verified; No violations found; Verified Objections: Jenkins: Violations found diff --git a/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryServiceServlet.java b/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryServiceServlet.java index 744b929..7cb492b 100644 --- a/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryServiceServlet.java +++ b/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryServiceServlet.java @@ -337,11 +337,18 @@ } private static void printField(PrintWriter pw, String name, String value, boolean comma) { + printFieldInternal(pw, name, "\"" + value + "\"", comma); + } + + private static void printField(PrintWriter pw, String name, long value, boolean comma) { + printFieldInternal(pw, name, String.valueOf(value), comma); + } + + private static void printFieldInternal(PrintWriter pw, String name, String value, boolean comma) { pw.print("\t\""); pw.print(name); - pw.print("\": \""); + pw.print("\": "); pw.print(value); - pw.print('"'); if (comma) { pw.print(','); } @@ -409,9 +416,9 @@ pw.print("\t"); printField(pw, Metrics.EXECUTION_TIME.str(), TimeUnit.formatNanos(executionTime)); pw.print("\t"); - printField(pw, Metrics.RESULT_COUNT.str(), String.valueOf(resultCount)); + printField(pw, Metrics.RESULT_COUNT.str(), resultCount, true); pw.print("\t"); - printField(pw, Metrics.RESULT_SIZE.str(), String.valueOf(resultSize), false); + printField(pw, Metrics.RESULT_SIZE.str(), resultSize, false); pw.print("\t}\n"); } -- To view, visit https://asterix-gerrit.ics.uci.edu/1496 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie330ba0e030d188adbf675741c382cf2754853f1 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann <ti...@apache.org> Gerrit-Reviewer: Ian Maxon <ima...@apache.org> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Michael Blow <mb...@apache.org> Gerrit-Reviewer: Till Westmann <ti...@apache.org> Gerrit-Reviewer: Yingyi Bu <buyin...@gmail.com>
