Change in asterixdb[master]: [NO ISSUE][OTH] Add function to validate primary key types

[AsterixDB Code Review]

>From Peeyush Gupta <peeyush.gu...@couchbase.com>:

Peeyush Gupta has uploaded this change for review. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17954 )


Change subject: [NO ISSUE][OTH] Add function to validate primary key types
......................................................................

[NO ISSUE][OTH] Add function to validate primary key types

- user model changes: no
- storage format changes: no
- interface changes: no

Change-Id: I07630be15f25cd140437e870cdeb4a7523363457
---
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java
1 file changed, 19 insertions(+), 0 deletions(-)



  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/54/17954/1

diff --git 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java
 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java
index 742bd42..927e5e7 100644
--- 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java
+++ 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java
@@ -957,6 +957,7 @@
                     List<IAType> partitioningTypes =
                             
ValidateUtil.validatePartitioningExpressions(aRecordType, metaRecType, 
partitioningExprs,
                                     keySourceIndicators, autogenerated, 
sourceLoc, partitioningExprTypes);
+                    validatePrimaryKeyType(partitioningTypes, sourceLoc);

                     List<String> filterField = ((InternalDetailsDecl) 
dd.getDatasetDetailsDecl()).getFilterField();
                     Integer filterSourceIndicator =
@@ -1900,6 +1901,11 @@
         ValidateUtil.validateIndexFieldType(indexType, fieldType, 
displayFieldName, sourceLoc);
     }

+    protected void validatePrimaryKeyType(List<IAType> fieldTypes, 
SourceLocation sourceLoc)
+            throws AlgebricksException {
+        // no op
+    }
+
     protected void handleCreateTypeStatement(MetadataProvider 
metadataProvider, Statement stmt) throws Exception {
         TypeDecl stmtCreateType = (TypeDecl) stmt;
         SourceLocation sourceLoc = stmtCreateType.getSourceLocation();

--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17954
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: I07630be15f25cd140437e870cdeb4a7523363457
Gerrit-Change-Number: 17954
Gerrit-PatchSet: 1
Gerrit-Owner: Peeyush Gupta <peeyush.gu...@couchbase.com>
Gerrit-MessageType: newchange