>From Vijay Sarathy <[email protected]>: Attention is currently required from: [email protected], Mehnaz Tabassum Mahin. Vijay Sarathy has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18140 )
Change subject: [NO ISSUE][COMP] Fix compile time errors in Distinct Cardinality Estimation ...................................................................... Patch Set 1: (1 comment) File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/cbo/EnumerateJoinsRule.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18140/comment/19c93832_e1bd56a9 PS1, Line 460: distinctVarsFuncPair.first, : distinctVarsFuncPair.second Minor: Pass these as one argument, and retrieve the components inside createDistinctOpsForNodes(). Makes the code easier to read with less parameters. Call as follows: OperatorUtils.createDistinctOpsForJoinNodes(nextOp, distinctVarsFuncPair, context, dataScanAndGroupByDistinctOps); -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18140 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I5e8d2d991535d68262462a9564f7f2e5e3432e3b Gerrit-Change-Number: 18140 Gerrit-PatchSet: 1 Gerrit-Owner: Mehnaz Tabassum Mahin <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Mehnaz Tabassum Mahin <[email protected]> Gerrit-Reviewer: Vijay Sarathy <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Attention: [email protected] Gerrit-Attention: Mehnaz Tabassum Mahin <[email protected]> Gerrit-Comment-Date: Thu, 25 Jan 2024 23:15:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
