>From Wail Alkowaileet <wael....@gmail.com>: Attention is currently required from: Savyasach Reddy. Wail Alkowaileet has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18253 )
Change subject: [ASTERIXDB-3390][STO]: Support GCS for cloud deployment ...................................................................... Patch Set 7: (4 comments) File asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/clients/google/gcs/GCSBufferedWriter.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18253/comment/370aa47a_7814bf5e PS6, Line 102: partNumber > Not necessary. I noticed that ICloudBufferedWriter. […] I see... We Can change int upload(InputStream stream, int length) in ICloudBufferedWriter to be void upload(InputStream stream, int length). The returned value isn't used. You can leave as is for now and we can remove it in a follow up patch https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18253/comment/e642e090_14023778 PS6, Line 104: setChunkSize > https://cloud.google.com/storage/docs/performing-resumable-uploads#:~:text=want%20to%20upload. > […] Done File asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/clients/google/gcs/GCSCloudClient.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18253/comment/d6c1a539_7278713f PS6, Line 100: list > No, It's added when we want to fetch the size of objects. The name is always > fetched. We will need the size. Let's include it here https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18253/comment/d26ab907_c1a90cb3 PS6, Line 121: seek > Checked it using a local gcs server. […] Done -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18253 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I0b9cad99de2d32d1e672a3d396897807687685e8 Gerrit-Change-Number: 18253 Gerrit-PatchSet: 7 Gerrit-Owner: Savyasach Reddy <savyasach.enuko...@couchbase.com> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-CC: Murtadha Hubail <mhub...@apache.org> Gerrit-CC: Wail Alkowaileet <wael....@gmail.com> Gerrit-Attention: Savyasach Reddy <savyasach.enuko...@couchbase.com> Gerrit-Comment-Date: Fri, 26 Apr 2024 16:51:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Wail Alkowaileet <wael....@gmail.com> Comment-In-Reply-To: Savyasach Reddy <savyasach.enuko...@couchbase.com> Gerrit-MessageType: comment
