>From Murtadha Hubail <mhub...@apache.org>: Attention is currently required from: Peeyush Gupta, Ali Alsuliman, Murtadha Hubail. Murtadha Hubail has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18257 )
Change subject: [ASTERIXDB-3391][OTH] Make DML statements cancellable ...................................................................... Patch Set 4: Code-Review+2 (1 comment) File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18257/comment/8494e701_3054a0e8 PS4, Line 4252: clientRequest.setJobId(jobId); Don't you need clientRequest.markCancellable(); after this? -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18257 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I16410ab9353c24597f77ab38ce06996fc5dfacd0 Gerrit-Change-Number: 18257 Gerrit-PatchSet: 4 Gerrit-Owner: Peeyush Gupta <peeyush.gu...@couchbase.com> Gerrit-Reviewer: Ali Alsuliman <ali.al.solai...@gmail.com> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Murtadha Hubail <mhub...@apache.org> Gerrit-Reviewer: Peeyush Gupta <peeyush.gu...@couchbase.com> Gerrit-Attention: Peeyush Gupta <peeyush.gu...@couchbase.com> Gerrit-Attention: Ali Alsuliman <ali.al.solai...@gmail.com> Gerrit-Attention: Murtadha Hubail Gerrit-Comment-Date: Sat, 04 May 2024 15:12:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
