>From Hussain Towaileb <hussai...@gmail.com>: Attention is currently required from: Murtadha Hubail, Ali Alsuliman, Michael Blow. Hussain Towaileb has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18263 )
Change subject: [NO ISSUE]: Track more requests + jobs counts ...................................................................... Patch Set 3: (3 comments) File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18263/comment/1b02a7b9_158486ca PS2, Line 532: catch (Exception ex) { : this.appCtx.getRequestTracker().incrementFailedRequests(); : throw ex; > What about ASYNC queries? Do we count them somewhere? Still looking into it. File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/api/IRequestTracker.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18263/comment/9bb6c96e_faad0e1e PS2, Line 91: gets > 'The' instead of 'gets' similar to the above ones. Done File hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/job/JobManager.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18263/comment/50761d9a_84ef0b61 PS2, Line 151: incrementCancelledJobs(); > What about the jobs that are PENDING (they are in the queue and not in the > activeRunMap)? They can g […] Done -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18263 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: trinity Gerrit-Change-Id: I8fa31a1e6bb6b1f1bcf90c59da646fc47546fc7c Gerrit-Change-Number: 18263 Gerrit-PatchSet: 3 Gerrit-Owner: Hussain Towaileb <hussai...@gmail.com> Gerrit-Reviewer: Ali Alsuliman <ali.al.solai...@gmail.com> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Hussain Towaileb <hussai...@gmail.com> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Michael Blow <mb...@apache.org> Gerrit-Reviewer: Murtadha Hubail <mhub...@apache.org> Gerrit-Attention: Murtadha Hubail <mhub...@apache.org> Gerrit-Attention: Ali Alsuliman <ali.al.solai...@gmail.com> Gerrit-Attention: Michael Blow <mb...@apache.org> Gerrit-Comment-Date: Thu, 09 May 2024 04:11:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Ali Alsuliman <ali.al.solai...@gmail.com> Gerrit-MessageType: comment
