>From Ritik Raj <raj.ritik9...@gmail.com>: Attention is currently required from: Murtadha Hubail, Wail Alkowaileet, Ali Alsuliman. Ritik Raj has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18264 )
Change subject: [ASTERIXDB-3394][STO] Introducing size bounded concurrent merge policy ...................................................................... Patch Set 10: (1 comment) File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/storage/SizeBoundedConcurrentMergePolicy.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18264/comment/98e82be2_1873449e PS8, Line 147: rangeLength >= localMinMergeComponentCount : && ((resultantComponentSize - currentComponentSize - oldestComponentSize) : * sizeRatio >= oldestComponentSize) > Extract as a method. It is always a good idea to have equations as a named > method/function. […] tried refactoring a bit, but does not seem much improvement on the if statements. -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18264 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I0cf0cfcfe5e7ff0131430ce2039ba89929fda274 Gerrit-Change-Number: 18264 Gerrit-PatchSet: 10 Gerrit-Owner: Ritik Raj <raj.ritik9...@gmail.com> Gerrit-Reviewer: Ali Alsuliman <ali.alsuli...@couchbase.com> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Murtadha Hubail <mhub...@apache.org> Gerrit-Reviewer: Ritik Raj <raj.ritik9...@gmail.com> Gerrit-Reviewer: Wail Alkowaileet Gerrit-CC: Wail Alkowaileet <wael....@gmail.com> Gerrit-Attention: Murtadha Hubail <mhub...@apache.org> Gerrit-Attention: Wail Alkowaileet <wael....@gmail.com> Gerrit-Attention: Ali Alsuliman <ali.alsuli...@couchbase.com> Gerrit-Attention: Wail Alkowaileet Gerrit-Comment-Date: Thu, 09 May 2024 18:10:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Wail Alkowaileet <wael....@gmail.com> Gerrit-MessageType: comment
