>From Hussain Towaileb <hussai...@gmail.com>: Attention is currently required from: Ali Alsuliman. Hussain Towaileb has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18298 )
Change subject: [NO ISSUE]: Avoid incrementing job counters for job cleanup tasks ...................................................................... Patch Set 4: Code-Review+1 (2 comments) File hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/job/JobManager.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18298/comment/db56acd8_cb0962e9 PS3, Line 240: boolean failed = run.getPendingStatus() == JobStatus.FAILURE; > Let's make it the opposite: […] Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18298/comment/0621bf88_ce62b68a PS3, Line 297: run.getExceptions() > Let's check first if exceptions is null or not just in case. Done -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18298 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: trinity Gerrit-Change-Id: I70cd1db750cd30930f61a790e5c1bc69f4f866cf Gerrit-Change-Number: 18298 Gerrit-PatchSet: 4 Gerrit-Owner: Hussain Towaileb <hussai...@gmail.com> Gerrit-Reviewer: Ali Alsuliman <ali.al.solai...@gmail.com> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Hussain Towaileb <hussai...@gmail.com> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Attention: Ali Alsuliman <ali.al.solai...@gmail.com> Gerrit-Comment-Date: Sun, 19 May 2024 18:15:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Ali Alsuliman <ali.al.solai...@gmail.com> Gerrit-MessageType: comment
