Michael Blow has posted comments on this change.

Change subject: Various fixes for Windows NCService
......................................................................


Patch Set 4:

(2 comments)

https://asterix-gerrit.ics.uci.edu/#/c/1518/4/asterixdb/asterix-server/src/main/opt/local/bin/start-sample-cluster.bat
File asterixdb/asterix-server/src/main/opt/local/bin/start-sample-cluster.bat:

PS4, Line 55: 
            : 
            : 
            : 
            : 
            : 
            : 
            : 
            : 
            : 
            : 
            : 
            : 
            : 
Why this deletion?  Did you test appassembler with spaces in JAVA_HOME?


https://asterix-gerrit.ics.uci.edu/#/c/1518/4/asterixdb/asterix-server/src/main/opt/local/bin/stop-sample-cluster.bat
File asterixdb/asterix-server/src/main/opt/local/bin/stop-sample-cluster.bat:

PS4, Line 61: 
            : 
            : 
            : 
            : 
            : 
            : 
            : 
            : 
            : 
            : 
Why this deletion?  Did you test appassembler with spaces in JAVA_HOME?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1518
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If7af80292bddd5191d83bac18f0a518621d7db71
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon <[email protected]>
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Reviewer: Michael Blow <[email protected]>
Gerrit-Reviewer: Yingyi Bu <[email protected]>
Gerrit-HasComments: Yes

Reply via email to