>From Murtadha Hubail <[email protected]>: Attention is currently required from: Ayush Tripathi. Murtadha Hubail has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19098 )
Change subject: [ASTERIXDB-3503][EXT] Fixing Internal Error issue when Delta table does not exists. ...................................................................... Patch Set 4: (3 comments) File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataUtils.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19098/comment/883dff91_67d7981b PS4, Line 518: validateDeltaTableExists This method is mostly duplicate from AwsS3DeltaReaderFactory#config. You should refactor if possible. Also, this method is S3 specific, so maybe it shouldn't be in this class or at least named accordingly. File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/aws/s3/S3Utils.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19098/comment/4dafd2b0_fd120c19 PS4, Line 343: if (isDeltaTable(configuration)) { : validateDeltaTableProperties(configuration); : validateDeltaTableExists(configuration); : } why did you move all of this here? You could just do the table check at the end https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19098/comment/02005841_e88f8090 PS4, Line 347: // check if the format property is present this isn't good for readability. Maybe add it inside the block. Also, you don't actually need this comment here. -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19098 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: goldfish Gerrit-Change-Id: I8d403c8c0698d9d39dc8988eb8b57588a684dbed Gerrit-Change-Number: 19098 Gerrit-PatchSet: 4 Gerrit-Owner: Ayush Tripathi <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-CC: Murtadha Hubail <[email protected]> Gerrit-Attention: Ayush Tripathi <[email protected]> Gerrit-Comment-Date: Thu, 21 Nov 2024 16:24:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
