>From Murtadha Hubail <[email protected]>: Attention is currently required from: Ayush Tripathi. Murtadha Hubail has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19098 )
Change subject: [ASTERIXDB-3503][EXT] Fixing Internal Error issue when Delta table does not exists. ...................................................................... Patch Set 8: Code-Review+2 (3 comments) File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/aws/delta/AwsS3DeltaReaderFactory.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19098/comment/ba13ff10_9cd37259 PS8, Line 192: configurationBuilder Method names should mostly start with a verb. The current name reads as if this method returns a configuration builder, but the method actually doesn't return anything. File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/aws/delta/DeltaFileRecordReader.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19098/comment/203268f5_e45701d8 PS8, Line 141: HyracksDataException.create(e); I don't think we are getting much from this, but it's okay to keep File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataUtils.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19098/comment/8303affe_3f9fd951 PS8, Line 526: } Ideally, you should fail here if it's not S3 to avoid the tableMetadataPath being null. -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19098 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: goldfish Gerrit-Change-Id: I8d403c8c0698d9d39dc8988eb8b57588a684dbed Gerrit-Change-Number: 19098 Gerrit-PatchSet: 8 Gerrit-Owner: Ayush Tripathi <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Attention: Ayush Tripathi <[email protected]> Gerrit-Comment-Date: Sat, 23 Nov 2024 15:22:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
