>From <[email protected]>: Attention is currently required from: Murtadha Hubail, Peeyush Gupta, Ali Alsuliman. [email protected] has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19006 )
Change subject: [ASTERIXDB-3531][COMP] Push projections into assign operator ...................................................................... Patch Set 26: (4 comments) File hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/AbstractAssignOperator.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19006/comment/52fde716_0851f713 PS16, Line 87: if (isProjectPushed()) { > Yeah, I thought AssignBatch is a different LogicalOperator. […] Done File hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/AbstractProjectPushableOperator.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19006/comment/4b79cc9a_0e6b995b PS16, Line 47: return projectPushed; > I saw a projection operator with empty variables in this test `temporal: > current_data_time_01` Done File hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/prettyprint/LogicalOperatorPrettyPrintVisitor.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19006/comment/fac6d0d6_766ceb86 PS25, Line 265: > You don't have to address in this patch, but any reason for this space? Done File hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/utils/LogicalOperatorDotVisitor.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19006/comment/6bbee34f_3b8bdf16 PS25, Line 225: > You don't have to address in this patch, but any reason for this space? No reason, will remove in a following patch -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19006 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I2767a176bb1d7bd7722121b9b8d57a8e9cf9de2a Gerrit-Change-Number: 19006 Gerrit-PatchSet: 26 Gerrit-Owner: [email protected] Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Peeyush Gupta <[email protected]> Gerrit-Attention: Murtadha Hubail <[email protected]> Gerrit-Attention: Peeyush Gupta <[email protected]> Gerrit-Attention: Ali Alsuliman <[email protected]> Gerrit-Comment-Date: Fri, 29 Nov 2024 10:59:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Murtadha Hubail <[email protected]> Comment-In-Reply-To: Ali Alsuliman <[email protected]> Comment-In-Reply-To: [email protected] Gerrit-MessageType: comment
