>From <[email protected]>: Attention is currently required from: Ali Alsuliman. [email protected] has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19100 )
Change subject: [ASTERIXDB-3531][COMP] Push projections into unnest operator ...................................................................... Patch Set 9: (5 comments) File hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/AbstractUnnestNonMapOperator.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19100/comment/d372cc4d_6a3b6404 PS8, Line 102: public VariablePropagationPolicy getVariablePropagationPolicy() { > We can use 'FilteredVariablePropagationPolicy': […] Done File hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/prettyprint/LogicalOperatorPrettyPrintVisitorJson.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19100/comment/fb6b8e14_7ab3c95e PS8, Line 1098: "project-variables" > We can replace this with PROJECT_VARIABLES_FIELD Done File hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/EmbedProjectRule.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19100/comment/9ada4358_663f6ad0 PS8, Line 49: LogicalOperatorTag.UNNEST > How about LogicalOperatorTag. […] Done File hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/std/UnnestRuntimeFactory.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19100/comment/aa031ca9_1713d548 PS8, Line 90: "unnest " + outCol + " <- " + unnestingFactory; > Change it to: […] Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19100/comment/1a3ec071_ae5b09b4 PS8, Line 149: for (int f = 0; f < projectionList.length; f++) { > We can simplify it: […] Done -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19100 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I83842976792f54017eff60fcc597bdd4ec6dc8c9 Gerrit-Change-Number: 19100 Gerrit-PatchSet: 9 Gerrit-Owner: [email protected] Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Attention: Ali Alsuliman <[email protected]> Gerrit-Comment-Date: Tue, 03 Dec 2024 08:15:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Ali Alsuliman <[email protected]> Gerrit-MessageType: comment
