>From <[email protected]>: Attention is currently required from: Peeyush Gupta. [email protected] has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19207 )
Change subject: [ASTERIXDB-3538][COMP] Remove subplan operators that produce empty variables ...................................................................... Patch Set 7: (1 comment) File hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/RemoveUnusedAssignAndAggregateRule.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19207/comment/04030419_0e538895 PS7, Line 277: subplanLocalLiveVars.removeAll(dataScanLiveVars); I just realised getProducedVariables is not recursive, getProducedInDescendantsAndSelf also doesn't work because it will contain datascan variables. I think subplanLocalLiveVars - dataScanLiveVars is the correct set, we should probably change the code above also if this is correct. -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19207 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: Ie123ccaafbd528d127bd91ecf0a6b5e93c497683 Gerrit-Change-Number: 19207 Gerrit-PatchSet: 7 Gerrit-Owner: [email protected] Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Peeyush Gupta <[email protected]> Gerrit-Attention: Peeyush Gupta <[email protected]> Gerrit-Comment-Date: Sun, 05 Jan 2025 08:37:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
