>From Murtadha Hubail <[email protected]>: Attention is currently required from: Michael Blow, Hussain Towaileb. Murtadha Hubail has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19246 )
Change subject: [ASTERIXDB-3514][EXT]: Support trust auth for parquet + delete assumed creds on collection drop ...................................................................... Patch Set 7: Code-Review+2 (2 comments) Patchset: PS7: Feel free to address the comment on a different patch File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19246/comment/fb25ceb6_ec77369f PS7, Line 2452: String.join(".", databaseName, dataverseName.getCanonicalForm(), datasetName) This is error prune. I know you can't call getName the way it is, but you should have the logic that constructs the name of the entity refactored somewhere or inside the entity itself and use it consistently. Also, isn't this ds.getDatasetFullyQualifiedName()? -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19246 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I77998a5dfcc304692e12280b7b4018f3593085b9 Gerrit-Change-Number: 19246 Gerrit-PatchSet: 7 Gerrit-Owner: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Attention: Michael Blow <[email protected]> Gerrit-Attention: Hussain Towaileb <[email protected]> Gerrit-Comment-Date: Thu, 16 Jan 2025 10:15:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
