Michael Blow has posted comments on this change. Change subject: Ansible scripts for local cluster installtion. ......................................................................
Patch Set 7: (8 comments) https://asterix-gerrit.ics.uci.edu/#/c/1525/7/asterixdb/asterix-server/src/main/opt/ansible/README File asterixdb/asterix-server/src/main/opt/ansible/README: PS7, Line 28: password-less passwordless seems like it's most commonly used here (even Google suggests it as alternative) PS7, Line 38: user name username PS7, Line 41: user name username https://asterix-gerrit.ics.uci.edu/#/c/1525/7/asterixdb/asterix-server/src/main/opt/ansible/bin/erase.sh File asterixdb/asterix-server/src/main/opt/ansible/bin/erase.sh: PS7, Line 29: installtion installation* https://asterix-gerrit.ics.uci.edu/#/c/1525/7/asterixdb/asterix-server/src/main/opt/ansible/conf/instance_settings.yml File asterixdb/asterix-server/src/main/opt/ansible/conf/instance_settings.yml: Line 33: basedir: "{{ ansible_env.HOME}}" insert space? https://asterix-gerrit.ics.uci.edu/#/c/1525/7/asterixdb/asterix-server/src/main/opt/ansible/conf/inventory File asterixdb/asterix-server/src/main/opt/ansible/conf/inventory: PS7, Line 21: user name username* https://asterix-gerrit.ics.uci.edu/#/c/1525/7/asterixdb/asterix-server/src/main/opt/ansible/yaml/instance_stop.yml File asterixdb/asterix-server/src/main/opt/ansible/yaml/instance_stop.yml: PS7, Line 23: kill -9 we probably want to not start out with kill -9, it is harsh way to kill JVM https://asterix-gerrit.ics.uci.edu/#/c/1525/7/asterixdb/asterix-server/src/main/opt/ansible/yaml/start_cc.yml File asterixdb/asterix-server/src/main/opt/ansible/yaml/start_cc.yml: PS7, Line 26: | spaces around pipe? -- To view, visit https://asterix-gerrit.ics.uci.edu/1525 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I310f6f198c9ce41d7d7667dc4fbc21b3e34a77ab Gerrit-PatchSet: 7 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-HasComments: Yes
