>From Ritik Raj <[email protected]>:

Ritik Raj has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19345 )

Change subject: [ASTERIXDB-3552][STO]: Checking response status while bulk 
deleting
......................................................................


Patch Set 4:

(1 comment)

File 
asterixdb/asterix-app/src/test/java/org/apache/asterix/api/common/LocalCloudUtil.java:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19345/comment/6398328d_04a5225f
PS4, Line 91: // create a storage container and delete stuff inside it, just to 
create a directory.
            :         PutObjectRequest putObjectRequest =
            :                 
PutObjectRequest.builder().bucket(CLOUD_STORAGE_BUCKET).key(STORAGE_DUMMY_FILE).build();
            :
            :         client.putObject(putObjectRequest, RequestBody.empty());
            :         // delete dummy file to retain storage directory.
            :         
client.deleteObject(DeleteObjectRequest.builder().bucket(CLOUD_STORAGE_BUCKET).key(STORAGE_DUMMY_FILE).build());
Mock S3 gives error, if there is nothing to delete, but the AWS S3 don't give 
error which is in sync with other object storage providers. Hence mimicking a 
storage/ folder so that the test runs fine.



--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19345
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: Id59be58699ffbfd64cb4d1ebf496e166eae070e4
Gerrit-Change-Number: 19345
Gerrit-PatchSet: 4
Gerrit-Owner: Ritik Raj <[email protected]>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Comment-Date: Tue, 21 Jan 2025 13:51:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Reply via email to