>From Vijay Sarathy <[email protected]>: Attention is currently required from: Peeyush Gupta, Ali Alsuliman. Vijay Sarathy has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19351 )
Change subject: [ASTERIXDB-3543][COMP] Do not inline expressions containing collection record ...................................................................... Patch Set 13: Code-Review+1 (5 comments) Patchset: PS13: l File hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/InlineSingleReferenceVariablesRule.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19351/comment/42331456_86fd8ea8 PS12, Line 57: List > We can use Set<> = new HashSet<> for both of these Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19351/comment/e125e4ee_c9dd046c PS12, Line 98: VariableUtilities.getProducedVariables(op, docRefVars); > Add a comment above this line saying that we should find a way to exclude > primary keys. Done File hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/InlineVariablesRule.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19351/comment/1dc0a38d_8bb0eefb PS12, Line 74: private Map<LogicalVariable, ILogicalExpression> varAssignRhs = new HashMap<>(); : private Map<LogicalVariable, ILogicalOperator> varAssignOp = new HashMap<>(); : // visitor for replacing variable reference expressions with their originating expression. : protected InlineVariablesVisitor inlineVisitor = new InlineVariablesVisitor(varAssignRhs, varAssignOp); : // set of FunctionIdentifiers that we should not inline. : protected Set<FunctionIdentifier> doNotInlineFuncs = new HashSet<>(); > Make those objects final. Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19351/comment/80e6be2f_c77f6e2a PS12, Line 318: private List<LogicalVariable> usedResultVars = new ArrayList<>(); : private List<LogicalVariable> docRefVars = new ArrayList<>(); > Those two can be Set Done -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19351 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: Ia818f11e45bf66e3b4807938bfb635c70fa9c496 Gerrit-Change-Number: 19351 Gerrit-PatchSet: 13 Gerrit-Owner: Vijay Sarathy <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Peeyush Gupta <[email protected]> Gerrit-Reviewer: Vijay Sarathy <[email protected]> Gerrit-Attention: Peeyush Gupta <[email protected]> Gerrit-Attention: Ali Alsuliman <[email protected]> Gerrit-Comment-Date: Fri, 31 Jan 2025 21:37:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Ali Alsuliman <[email protected]> Gerrit-MessageType: comment
