>From Murtadha Hubail <[email protected]>: Attention is currently required from: Michael Blow, Hussain Towaileb. Murtadha Hubail has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19365 )
Change subject: [ASTERIXDB-3514][EXT]: Pass entity-id for all creds required operations ...................................................................... Patch Set 8: Code-Review+2 (6 comments) Patchset: PS8: Please feel free to address the comments on a different patch File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19365/comment/42e253e6_ea186b69 PS8, Line 4060: preparePropertiesCopyForValidation no need for extra copy? https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19365/comment/0cff9488_cdafa661 PS8, Line 4158: setExternalEntityIdFromParts(properties, databaseName, dataverseName, uuid, true); as discussed, let's clean this API or just reuse setExternalEntityId https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19365/comment/04e970b6_a760ee47 PS8, Line 5588: postRequestCompleteCleanup(requestParameters); If someone doesn't call this after a complete, then the cached resources will be there until they expire. We need to improve the lifecycle and make it based on the request or the job lifecycle itself. File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/external/IExternalCredentialsCache.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19365/comment/c0a9f3fe_aabeac53 PS8, Line 47: String type Ideally, the cache isn't care about the type File asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/MetadataProvider.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19365/comment/5048d54d_65529d6f PS8, Line 1014: setExternalEntityIdFromParts As discussed, we could potentially get rid of this completely -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19365 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: If5bd9ed7c1fc0aedba7f7bb90acb48c2edf3d580 Gerrit-Change-Number: 19365 Gerrit-PatchSet: 8 Gerrit-Owner: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Attention: Michael Blow <[email protected]> Gerrit-Attention: Hussain Towaileb <[email protected]> Gerrit-Comment-Date: Tue, 04 Feb 2025 13:54:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
