>From Hussain Towaileb <[email protected]>: Hussain Towaileb has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19386 )
Change subject: [ASTERIXDB-3514][EXT]: Cleanup on S3 cross-account auth ...................................................................... Patch Set 1: (1 comment) File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/external/ExternalCredentialsCache.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19386/comment/152b4c91_f2f7d6be PS1, Line 63: awsAssumeRoleDuration > Duration needs to be passed alongside the credentials object, so is the > threshold percentage. […] Or better, each put adds the credentials, its duration and threshold, and it's stored as part of TemporaryCredentials. This way, each credentials knows when it needs to expire, no need for global parameters. -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19386 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: Iba5dfd5e077f87aa0c1ee1cc81fcf197c9f06762 Gerrit-Change-Number: 19386 Gerrit-PatchSet: 1 Gerrit-Owner: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-CC: Anon. E. Moose #1000171 Gerrit-Comment-Date: Wed, 05 Feb 2025 13:46:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Hussain Towaileb <[email protected]> Gerrit-MessageType: comment
