>From Ali Alsuliman <[email protected]>: Ali Alsuliman has submitted this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19492 )
Change subject: [ASTERIXDB-3536][COMP] Pass heterogeneous index flag when validating fields types ...................................................................... [ASTERIXDB-3536][COMP] Pass heterogeneous index flag when validating fields types - user model changes: no - storage format changes: no - interface changes: no Ext-ref: MB-27845 Change-Id: Icab29b7c2c530f7e2a0ac01ca923d1cf92bed008 Reviewed-on: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19492 Integration-Tests: Jenkins <[email protected]> Reviewed-by: Ali Alsuliman <[email protected]> Reviewed-by: Murtadha Hubail <[email protected]> Tested-by: Jenkins <[email protected]> --- M asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java 1 file changed, 22 insertions(+), 2 deletions(-) Approvals: Murtadha Hubail: Looks good to me, approved Ali Alsuliman: Looks good to me, but someone else must approve Jenkins: Verified; Verified diff --git a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java index fde71f8..c8885dc 100644 --- a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java +++ b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java @@ -1562,7 +1562,8 @@ throw new CompilationException(ErrorCode.COMPILATION_ERROR, indexedElement.getSourceLocation(), "Cannot specify exclude/include unknown for untyped keys in the index definition."); } - validateIndexFieldType(indexType, fieldTypePrime, projectPath, indexedElement.getSourceLocation()); + validateIndexFieldType(indexType, fieldTypePrime, projectPath, indexedElement.getSourceLocation(), + isHeterogeneousIndex); IAType fieldType = KeyFieldTypeUtil.makeUnknownableType(fieldTypePrime, fieldTypeNullable, fieldTypeMissable); @@ -1988,7 +1989,7 @@ } protected void validateIndexFieldType(IndexType indexType, IAType fieldType, List<String> displayFieldName, - SourceLocation sourceLoc) throws AlgebricksException { + SourceLocation sourceLoc, boolean isHeterogeneousIndex) throws AlgebricksException { ValidateUtil.validateIndexFieldType(indexType, fieldType, displayFieldName, sourceLoc); } -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19492 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: Icab29b7c2c530f7e2a0ac01ca923d1cf92bed008 Gerrit-Change-Number: 19492 Gerrit-PatchSet: 3 Gerrit-Owner: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Peeyush Gupta <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-MessageType: merged
