>From <[email protected]>: Attention is currently required from: [email protected]. [email protected] has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19489 )
Change subject: [ASTERIXDB-3571][COMP] Infer selection predicates from join predicates ...................................................................... Patch Set 13: Code-Review+1 (4 comments) File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/cbo/JoinEnum.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19489/comment/bdef9258_da938eff PS9, Line 300: } else if (andExpr.getArguments().size() > 1) { > Why do we avoid using AND expressions in nested loop joins? Some rule in RBO that wants only one condition. https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19489/comment/e96e9e43_99762e68 PS9, Line 1269: private void addTCpredicates(List<SelectOperator> existingSelOps) throws AlgebricksException { > Since there is already a function addTCPreds() that adds join transitive > closures, consider renaming […] will do. https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19489/comment/df319965_e3914b2a PS9, Line 1356: private boolean simpleCondition(ILogicalExpression condition) { > We don't require the operation to be EQ, right? No. It can be any op. https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19489/comment/89ee92f7_c49b21f2 PS9, Line 1362: if (arg0.getValue() instanceof VariableReferenceExpression > you can use arg0.getValue().getExpressionTag() == VARIABLE && > arg1.getValue().. […] done -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19489 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: Iac01b5eba1b35d66e50d86205ddef05fb86c334a Gerrit-Change-Number: 19489 Gerrit-PatchSet: 13 Gerrit-Owner: [email protected] Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: [email protected] Gerrit-CC: Peeyush Gupta <[email protected]> Gerrit-Attention: [email protected] Gerrit-Comment-Date: Wed, 12 Mar 2025 01:21:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: [email protected] Gerrit-MessageType: comment
