>From Ritik Raj <[email protected]>: Attention is currently required from: Peeyush Gupta, Ali Alsuliman. Ritik Raj has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19532 )
Change subject: [ASTERIXDB-3582][COMP] Fix expected schema tree generation ...................................................................... Patch Set 2: (3 comments) File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/pushdown/schema/ExpectedSchemaBuilder.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19532/comment/04c47577_9a70f6e9 PS1, Line 70: producedVar != null > If the (new) actual node is different from oldNode, it must be the case that > producedVar is not null […] yes File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/pushdown/schema/ObjectExpectedSchemaNode.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19532/comment/bc3b1997_753fa91a PS1, Line 105: typeEnv > Do we need the typeEnv as part of the method signature? It seems that you can > refactor getChildField […] the caller does not have direct access to the expr, it comes from the caller's parent. File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/pushdown/schema/RootExpectedSchemaNode.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19532/comment/bb96f036_ab897589 PS1, Line 38: ROOT_EXPECTED_SCHEMA_NODES > For a simple case like this, I think a boolean method > isExpectedRootNode(IExpectedSchemaNode n) or s […] Done -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19532 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: ionic Gerrit-Change-Id: Ic04a618c7aa182af4b1f4b7ade64d687147ef705 Gerrit-Change-Number: 19532 Gerrit-PatchSet: 2 Gerrit-Owner: Ritik Raj <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Peeyush Gupta <[email protected]> Gerrit-Attention: Peeyush Gupta <[email protected]> Gerrit-Attention: Ali Alsuliman <[email protected]> Gerrit-Comment-Date: Fri, 21 Mar 2025 18:02:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Ali Alsuliman <[email protected]> Gerrit-MessageType: comment
