>From Ritik <[email protected]>: Attention is currently required from: Peeyush Gupta, Ali Alsuliman. Ritik has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19532 )
Change subject: [ASTERIXDB-3582][COMP] Fix expected schema tree generation ...................................................................... Patch Set 5: (3 comments) File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/pushdown/schema/ExpectedSchemaBuilder.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19532/comment/04be92b2_6878570b PS1, Line 70: producedVar != null > yes Done File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/pushdown/schema/RootExpectedSchemaNode.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19532/comment/a0e04bfb_d6806333 PS4, Line 86: List.of(ALL_FIELDS_ROOT_NODE, ALL_FIELDS_ROOT_IRREPLACEABLE_NODE, EMPTY_ROOT_NODE).contains(node); > Use ||'s Done File asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/column/filter/ASTERIXDB-3582-2/ASTERIXDB-3582-2.006.query.sqlpp: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19532/comment/ec176e03_45794495 PS1, Line 20: -- there was issue in expected schema tree generation for i and li.qty > *Added Done -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19532 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: ionic Gerrit-Change-Id: Ic04a618c7aa182af4b1f4b7ade64d687147ef705 Gerrit-Change-Number: 19532 Gerrit-PatchSet: 5 Gerrit-Owner: Ritik <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Peeyush Gupta <[email protected]> Gerrit-Attention: Peeyush Gupta <[email protected]> Gerrit-Attention: Ali Alsuliman <[email protected]> Gerrit-Comment-Date: Sat, 22 Mar 2025 09:25:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Ali Alsuliman <[email protected]> Comment-In-Reply-To: Ritik <[email protected]> Gerrit-MessageType: comment
