abdullah alamoudi has posted comments on this change. Change subject: Cleanup and bug fixes in Feeds pipeline ......................................................................
Patch Set 8: (2 comments) https://asterix-gerrit.ics.uci.edu/#/c/1523/8/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/operators/FeedIntakeOperatorNodePushable.java File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/operators/FeedIntakeOperatorNodePushable.java: PS8, Line 64: writer.open(); > why close() if open() fails? it looks like this will fail in at least some Maybe we should revisit this but as per the IFrameWriter contract, if open is called, close must be called even if open fails. https://asterix-gerrit.ics.uci.edu/#/c/1523/8/hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/freepage/ArrayValueReference.java File hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/freepage/ArrayValueReference.java: Line 23: public class ArrayValueReference implements IValueReference { > This seems mutable still, why the name change? Done -- To view, visit https://asterix-gerrit.ics.uci.edu/1523 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie97b2133ebecb7380cf0ba336e60ed714d06f8ee Gerrit-PatchSet: 8 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <bamou...@gmail.com> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Michael Blow <mb...@apache.org> Gerrit-Reviewer: abdullah alamoudi <bamou...@gmail.com> Gerrit-HasComments: Yes