>From Hussain Towaileb <hussai...@gmail.com>: Attention is currently required from: Michael Blow. Hussain Towaileb has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19525 )
Change subject: [ASTERIXDB-3581][EXT]: Do not retry GCS SDK requests if thread is interrupted ...................................................................... Patch Set 5: (3 comments) File asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/clients/google/gcs/GCSCloudClient.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19525/comment/345b86de_ee68867d PS3, Line 80: private final ExecutorService executor; > we can probably delete this field if we no longer require an executor Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19525/comment/d17911f8_30af65ed PS3, Line 83: ExecutorService executor > we can probably delete this parameter if we no longer require an executor Done File asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/clients/google/gcs/GCSParallelDownloader.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19525/comment/75fdd450_c12d169f PS3, Line 139: try { > this causes us to leak clients if the transfer manager close fails- revert. Done -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19525 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: ionic Gerrit-Change-Id: I5deb956bda11ee2ca41a1c05616788b2d697622f Gerrit-Change-Number: 19525 Gerrit-PatchSet: 5 Gerrit-Owner: Hussain Towaileb <hussai...@gmail.com> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-CC: Michael Blow <mb...@apache.org> Gerrit-Attention: Michael Blow <mb...@apache.org> Gerrit-Comment-Date: Tue, 18 Mar 2025 15:33:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Michael Blow <mb...@apache.org> Gerrit-MessageType: comment
