>From Ritik Raj <[email protected]>:

Attention is currently required from: Murtadha Hubail, Peeyush Gupta, Ali 
Alsuliman.
Ritik Raj has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19555 )

Change subject: [ASTERIXDB-3586][STO] Sync tupleIndex while skipping tuples
......................................................................


Patch Set 11:

(5 comments)

Commit Message:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19555/comment/95094268_47670532
PS4, Line 16: filter’s `tupleIndex`. This misalignment between the filter and 
assembler
            : ca
> fix this please
Done


https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19555/comment/282f74ea_fff970f9
PS4, Line 19: rrectness.
> add Ext-ref
Done


Patchset:

PS10:
> LGTM, however I feel we should be able to reproduce this issue if we somehow 
> have a  […]
lets say we generate the component as

1st disk component
-----------------
4,4
5,5
6,6

2nd disk component
------------------
1,1
2,2
3,3
4,A
5,A
6,A

when we run a query for val > 3.

the range filter will skip 2nd DiskComponent, as none of the tuple satisfies 
the condition, and for 1st DiskComponent, every entry will be skipped as 
deleted in later disk component.


File 
asterixdb/asterix-column/src/main/java/org/apache/asterix/column/filter/iterable/evaluator/ColumnIterableFilterEvaluator.java:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19555/comment/f7bd4663_1c122bc1
PS4, Line 36:  // if the next() returns false, if no tuples satisfies after the 
last tuple
> improve this comment
Done


File 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree-column/src/main/java/org/apache/hyracks/storage/am/lsm/btree/column/api/IColumnTupleIterator.java:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19555/comment/df8a8e91_646cb79e
PS4, Line 82: while
> on
Done



--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19555
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: ionic
Gerrit-Change-Id: I260612851c4dabfb9e74f2902f421720d9f88657
Gerrit-Change-Number: 19555
Gerrit-PatchSet: 11
Gerrit-Owner: Ritik Raj <[email protected]>
Gerrit-Reviewer: Ali Alsuliman <[email protected]>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Reviewer: Murtadha Hubail <[email protected]>
Gerrit-Reviewer: Peeyush Gupta <[email protected]>
Gerrit-Reviewer: Ritik Raj <[email protected]>
Gerrit-Attention: Murtadha Hubail <[email protected]>
Gerrit-Attention: Peeyush Gupta <[email protected]>
Gerrit-Attention: Ali Alsuliman <[email protected]>
Gerrit-Comment-Date: Thu, 10 Apr 2025 12:23:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Murtadha Hubail <[email protected]>
Comment-In-Reply-To: Peeyush Gupta <[email protected]>
Gerrit-MessageType: comment

Reply via email to