>From Ritik Raj <[email protected]>: Ritik Raj has submitted this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19645 )
Change subject: [ASTERIXDB-3597][STO] Using interior frame slot size ...................................................................... [ASTERIXDB-3597][STO] Using interior frame slot size - user model changes: no - storage format changes: no - interface changes: no Details: Previously, we use the leaf frame's slot size for interior frames, which is set as 0 for column leaf frame. This caused underestimation of space when writing tuples into interior frames (guide nodes). Tuples are written left to right, while slot metadata is written right to left. The 4-byte underestimation per tuple could lead the frame to incorrectly believe it can accommodate a tuple. This may cause tuple data to overlap with the slot region, resulting in corruption. This change uses interiorSlotSize for writing interior row guide nodes, fixing the underestimation. Ext-ref: MB-66227 Change-Id: Id734699118713f4754fb3ef0b93fdb9b314b448b Reviewed-on: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19645 Integration-Tests: Jenkins <[email protected]> Tested-by: Jenkins <[email protected]> Reviewed-by: Peeyush Gupta <[email protected]> --- M hyracks-fullstack/hyracks/hyracks-storage-am-btree/src/main/java/org/apache/hyracks/storage/am/btree/impls/BTreeNSMBulkLoader.java A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/column/io/merge/ASTERIXDB-3597/ASTERIXDB-3597.004.query.sqlpp M hyracks-fullstack/hyracks/hyracks-storage-am-btree/src/main/java/org/apache/hyracks/storage/am/btree/frames/BTreeNSMInteriorFrame.java A asterixdb/asterix-app/src/test/resources/runtimets/results/column/io/merge/ASTERIXDB-3597/ASTERIXDB-3597.004.adm M hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/impls/AbstractTreeIndexBulkLoader.java A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/column/io/merge/ASTERIXDB-3597/ASTERIXDB-3597.001.ddl.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/results/column/io/flush/ASTERIXDB-3597/ASTERIXDB-3597.003.adm A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/column/io/flush/ASTERIXDB-3597/ASTERIXDB-3597.001.ddl.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/column/io/flush/ASTERIXDB-3597/ASTERIXDB-3597.003.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/column/io/flush/ASTERIXDB-3597/ASTERIXDB-3597.002.update.sqlpp M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_single_partition_sqlpp.xml A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/column/io/merge/ASTERIXDB-3597/ASTERIXDB-3597.003.update.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/column/io/merge/ASTERIXDB-3597/ASTERIXDB-3597.002.update.sqlpp 13 files changed, 442 insertions(+), 2 deletions(-) Approvals: Peeyush Gupta: Looks good to me, approved Jenkins: Verified; Verified Anon. E. Moose #1000171: -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19645 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: ionic Gerrit-Change-Id: Id734699118713f4754fb3ef0b93fdb9b314b448b Gerrit-Change-Number: 19645 Gerrit-PatchSet: 6 Gerrit-Owner: Ritik Raj <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Peeyush Gupta <[email protected]> Gerrit-Reviewer: Ritik Raj <[email protected]> Gerrit-MessageType: merged
