>From Ali Alsuliman <[email protected]>: Attention is currently required from: Murtadha Hubail, Peeyush Gupta. Ali Alsuliman has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19730 )
Change subject: [ASTERIXDB-3603][FUN] Adding validation for transform functions ...................................................................... Patch Set 4: Code-Review+2 (3 comments) File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/visitor/FunctionCardinalityInferenceVisitor.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19730/comment/10c1ae79_e333a71d PS4, Line 49: op.getMaxObjects() Don't we need to check if hasMaxObjects()? I think this will happen if you only have OFFSET without LIMIT. File asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/function/transform/positive/transform.001.ddl.sqlpp: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19730/comment/c5da1212_ea86bc2d PS4, Line 21: -- Fail: More than one argument I believe this is type, right? (same thing for the other ones in this positive test case) https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19730/comment/508e0daa_91c477d4 PS4, Line 24: SELECT count(*) as count FROM [doc] t UNNEST t.a We can add one more test (whether negative or positive) that does GROUP BY t.some_field -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19730 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I524cbfb6685bd3c7ed269c2db48482e5aba1ce6c Gerrit-Change-Number: 19730 Gerrit-PatchSet: 4 Gerrit-Owner: Peeyush Gupta <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Attention: Murtadha Hubail <[email protected]> Gerrit-Attention: Peeyush Gupta <[email protected]> Gerrit-Comment-Date: Thu, 08 May 2025 16:45:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
